我在下面编写了一个函数,用于格式化字符串。它删除空格和字符“-”。然后每3个字符后插入一个空格。我
malloc()
函数中有两个字符串,但仅I
free()
在我退出函数之前,其中一个。我想这是内存泄漏的一个例子。有没有一种方法可以更好地设计此函数,以避免像这样泄漏内存?
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
char* FormatString(char* s) {
/*Get string length*/
int original_str_length = strlen(s);
int num_elements_to_delete = 0;
int i=0;
int j=0;
/*count chars '-' and ' ' to delete*/
for (int i=0; i <= original_str_length; i++) {
if((s[i] == '-') || (s[i] == ' ')) {
num_elements_to_delete++;
}
}
/*allocate new string to hold string minus '-' and ' '*/
char* string_minus_chars = (char *) malloc(original_str_length - num_elements_to_delete);
for (i=0; i <= original_str_length; i++) {
/*if char is not '-' or ' ' copy to new string*/
if((s[i] != '-') && (s[i] != ' ')) {
string_minus_chars[j] = s[i];
j++;
}
}
/*Print the string*/
printf("String minus chars is %s\r\n", string_minus_chars);
int string_minus_chars_length = strlen(string_minus_chars);
printf("string_minus_chars_length %d\r\n", string_minus_chars_length);
int extra_spaces = (string_minus_chars_length) / 3;
printf("Number of spaces needed is %d\r\n", extra_spaces);
/*allocate new string with spaces*/
char* string_with_spaces = (char *) malloc(sizeof(char)*(extra_spaces + string_minus_chars_length));
int space_counter = 0;
int index = 0;
for (i=0; i <= strlen(string_with_spaces); i++) {
if(space_counter == 3) {
printf("str2 index is %d, str1 index is %d,space counter is %d, inserting space\r\n",i, index, space_counter);
string_with_spaces[i] = ' ';
space_counter = 0;
}
else {
printf("str2 index is %d,str1 index is %d,space counter is %d, copying %c\r\n", i, index,space_counter, string_minus_chars[index]);
string_with_spaces[i] = string_minus_chars[index];
space_counter++;
index++;
}
}
printf("String_with_spaces is:%s\r\n", string_with_spaces);
free(string_minus_chars);
return string_with_spaces;
}
int main(void) {
char s[12] = "ABC-3-26--54";
char* string_returned;
string_returned = FormatString(s);
printf("String returned is %s",string_returned);
}