代码之家 › 专栏 › 技术社区 › Shpigford

重构:find查询中有多个参数

refactoring ruby-on-rails

Shpigford · 技术社区 · 14 年前

需要一些帮助来重构这个if/else块,该块为find查询构建条件。

if params[:status] && params[:carrier]
  conditions = ["actual_delivery IS NOT NULL AND actual_delivery > scheduled_delivery AND status_id = ? AND carrier_id = ?", status.id, carrier.id]
elsif params[:status]
  conditions = ["actual_delivery IS NOT NULL AND actual_delivery > scheduled_delivery AND status_id = ?", status.id]
elsif params[:carrier]
  conditions = ["actual_delivery IS NOT NULL AND actual_delivery > scheduled_delivery AND carrier_id = ?", carrier.id]
else
  conditions = ["actual_delivery IS NOT NULL AND actual_delivery > scheduled_delivery"]
end

@packages = Package.find(:all, :conditions => conditions)

2 回复 | 直到 14 年前

jordinl 14 年前

conditions = "actual_delivery IS NOT NULL AND actual_delivery > scheduled_delivery"
conditions += " AND status_id = #{status.id}" if params[:status]
conditions += " AND carrier_id = #{carrier.id}" if params[:carrier]

@packages = Package.all(:conditions => [conditions])

Jaime Bellmyer 14 年前

class Package < ActiveRecord::Base
  named_scope :late_deliveries, :conditions => "actual_delivery IS NOT NULL AND actual_delivery > scheduled_delivery"
end

def index
  conditions = {}
  [:status, :carrer].each{|param| conditions[param] = params[param] if params[param]}

  @packages = Package.late_deliveries.find(:conditions => conditions)
end

def index
  @packages = Package.late_deliveries.find(:conditions => params)
end

推荐文章

aarona · Rails迁移批量更新change_column_default

4 月前

cluster1 · 采取独立的新行动的好处是什么?

6 月前

Robert · 使用JSON或哈希时,将NULL替换为NIL

7 月前

cluster1 · Rails form_with-helper:什么是:作用域?

11 月前

stevec Zxeenu · 如何在rails控制台中禁用寻呼机,以便将整个结果打印到控制台?

1 年前

Fred Willmore · Rails控制器不呈现任何模板

1 年前

Diogo Amaral · 实现API请求的正确方式

1 年前

Meknassih · 在控制器方法中分配给模型没有任何作用

1 年前

Michael Ding · Rails上的默认会话到期问题

1 年前

Flávio · 基于另外两个生成数组

1 年前