Cakephp标准-在控制器中写东西是正确的标准吗

对不起,这个基本问题。以下是Userscontroller.php中显示的代码

public function register()
{
  //Setting some data
  $this->User->create();
  $this->User->save($this->request->data)
} 

public function edit()
{
  //Setting some data
  $this->User->save($this->request->data)
} 

public function admin_add()
{
  //Setting some data
  $this->User->create();
  $this->User->save($this->request->data)
} 

public function admin_edit()
{
  //Setting some data
  $this->User->save($this->request->data)
} 

我的一位学长审阅了这段代码,并说上面的代码不符合CAKEPHP标准。。业务逻辑需要转向模型

如模型中所示

<?php 
class User extends AppModel {
  //Validation parts

     public functions savingData($data =array(), $id=false)
    {
       if($id == false)
       {
         $this->create();
       }
       $this->User->save($data)
    }
}?>

在控制器中,他要求将其称为 保存数据 创建和更新选项的函数